minor_change.patch.txt

text/plain

Filename: minor_change.patch.txt
Type: text/plain
Part: 0
Message: Re: Add contrib/pg_logicalsnapinspect
commit 483f5a402b6f650d02e8f8668bd50b17680f2805
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date:   Fri Oct 11 15:52:49 2024 -0700

    minor changes

diff --git a/contrib/pg_logicalinspect/pg_logicalinspect--1.0.sql b/contrib/pg_logicalinspect/pg_logicalinspect--1.0.sql
index c773f6e458..8f7f947cbb 100644
--- a/contrib/pg_logicalinspect/pg_logicalinspect--1.0.sql
+++ b/contrib/pg_logicalinspect/pg_logicalinspect--1.0.sql
@@ -31,9 +31,9 @@ CREATE FUNCTION pg_get_logical_snapshot_info(IN filename text,
     OUT in_slot_creation boolean,
     OUT last_serialized_snapshot pg_lsn,
     OUT next_phase_at xid,
-    OUT committed_count int8,
+    OUT committed_count int4,
     OUT committed_xip xid[],
-    OUT catchange_count int8,
+    OUT catchange_count int4,
     OUT catchange_xip xid[]
 )
 AS 'MODULE_PATHNAME', 'pg_get_logical_snapshot_info'
diff --git a/contrib/pg_logicalinspect/pg_logicalinspect.c b/contrib/pg_logicalinspect/pg_logicalinspect.c
index fabfe2a10c..790c64d6fa 100644
--- a/contrib/pg_logicalinspect/pg_logicalinspect.c
+++ b/contrib/pg_logicalinspect/pg_logicalinspect.c
@@ -123,7 +123,7 @@ pg_get_logical_snapshot_info(PG_FUNCTION_ARGS)
 	values[i++] = LSNGetDatum(ondisk.builder.last_serialized_snapshot);
 	values[i++] = TransactionIdGetDatum(ondisk.builder.next_phase_at);
 
-	values[i++] = Int64GetDatum(ondisk.builder.committed.xcnt);
+	values[i++] = UInt32GetDatum(ondisk.builder.committed.xcnt);
 	if (ondisk.builder.committed.xcnt > 0)
 	{
 		Datum	   *arrayelems;
@@ -140,7 +140,7 @@ pg_get_logical_snapshot_info(PG_FUNCTION_ARGS)
 	else
 		nulls[i++] = true;
 
-	values[i++] = Int64GetDatum(ondisk.builder.catchange.xcnt);
+	values[i++] = UInt32GetDatum(ondisk.builder.catchange.xcnt);
 	if (ondisk.builder.catchange.xcnt > 0)
 	{
 		Datum	   *arrayelems;
diff --git a/doc/src/sgml/pglogicalinspect.sgml b/doc/src/sgml/pglogicalinspect.sgml
index e0fac997b6..4b111f9611 100644
--- a/doc/src/sgml/pglogicalinspect.sgml
+++ b/doc/src/sgml/pglogicalinspect.sgml
@@ -22,7 +22,7 @@
  </para>
 
  <sect2 id="pglogicalinspect-funcs">
-  <title>General Functions</title>
+  <title>Functions</title>
 
   <variablelist>
    <varlistentry id="pglogicalinspect-funcs-pg-get-logical-snapshot-meta">