PS_NITPICKS_GENCOLS_v360001.txt

text/plain

Filename: PS_NITPICKS_GENCOLS_v360001.txt
Type: text/plain
Part: 0
Message: Re: Pgoutput not capturing the generated columns
diff --git a/src/test/regress/expected/publication.out b/src/test/regress/expected/publication.out
index 8bcb79a..e419ca8 100644
--- a/src/test/regress/expected/publication.out
+++ b/src/test/regress/expected/publication.out
@@ -1774,26 +1774,20 @@ CREATE PUBLICATION pub2 FOR ALL TABLES WITH (publish_generated_columns=0);
  regress_publication_user | t          | t       | t       | t       | t         | f        | f
 (1 row)
 
-RESET client_min_messages;
 DROP PUBLICATION pub1;
 DROP PUBLICATION pub2;
 -- Test the 'publish_generated_columns' parameter enabled or disabled for
 -- different scenarios with/without generated columns in column lists.
-SET client_min_messages = 'WARNING';
 CREATE TABLE gencols (a int, gen1 int GENERATED ALWAYS AS (a * 2) STORED);
--- gencols in column list with 'publish_generated_columns'=false
+-- Generated columns in column list, when 'publish_generated_columns'=false
 CREATE PUBLICATION pub1 FOR table gencols(a, gen1) WITH (publish_generated_columns=false);
-WARNING:  "wal_level" is insufficient to publish logical changes
-HINT:  Set "wal_level" to "logical" before creating subscriptions.
--- gencols in column list with 'publish_generated_columns'=true
+-- Generated columns in column list, when 'publish_generated_columns'=true
 CREATE PUBLICATION pub2 FOR table gencols(a, gen1) WITH (publish_generated_columns=true);
-WARNING:  "wal_level" is insufficient to publish logical changes
-HINT:  Set "wal_level" to "logical" before creating subscriptions.
--- gencols in column list, then set 'publication_generate_columns'=false
+-- Generated columns in column list, then set 'publication_generate_columns'=false
 ALTER PUBLICATION pub2 SET (publish_generated_columns = false);
--- remove gencols from column list, when 'publish_generated_columns'=false
+-- Remove generate columns from column list, when 'publish_generated_columns'=false
 ALTER PUBLICATION pub2 SET TABLE gencols(a);
--- Add gencols in column list, when 'publish_generated_columns'=false.
+-- Add generated columns in column list, when 'publish_generated_columns'=false
 ALTER PUBLICATION pub2 SET TABLE gencols(a, gen1);
 DROP PUBLICATION pub1;
 DROP PUBLICATION pub2;
diff --git a/src/test/regress/sql/publication.sql b/src/test/regress/sql/publication.sql
index 6a74fd6..9724ba3 100644
--- a/src/test/regress/sql/publication.sql
+++ b/src/test/regress/sql/publication.sql
@@ -1118,32 +1118,29 @@ DROP SCHEMA sch2 cascade;
 SET client_min_messages = 'ERROR';
 CREATE PUBLICATION pub1 FOR ALL TABLES WITH (publish_generated_columns=1);
 \dRp+ pub1
-
 CREATE PUBLICATION pub2 FOR ALL TABLES WITH (publish_generated_columns=0);
 \dRp+ pub2
 
-RESET client_min_messages;
 DROP PUBLICATION pub1;
 DROP PUBLICATION pub2;
 
 -- Test the 'publish_generated_columns' parameter enabled or disabled for
 -- different scenarios with/without generated columns in column lists.
-SET client_min_messages = 'WARNING';
 CREATE TABLE gencols (a int, gen1 int GENERATED ALWAYS AS (a * 2) STORED);
 
--- gencols in column list with 'publish_generated_columns'=false
+-- Generated columns in column list, when 'publish_generated_columns'=false
 CREATE PUBLICATION pub1 FOR table gencols(a, gen1) WITH (publish_generated_columns=false);
 
--- gencols in column list with 'publish_generated_columns'=true
+-- Generated columns in column list, when 'publish_generated_columns'=true
 CREATE PUBLICATION pub2 FOR table gencols(a, gen1) WITH (publish_generated_columns=true);
 
--- gencols in column list, then set 'publication_generate_columns'=false
+-- Generated columns in column list, then set 'publication_generate_columns'=false
 ALTER PUBLICATION pub2 SET (publish_generated_columns = false);
 
--- remove gencols from column list, when 'publish_generated_columns'=false
+-- Remove generate columns from column list, when 'publish_generated_columns'=false
 ALTER PUBLICATION pub2 SET TABLE gencols(a);
 
--- Add gencols in column list, when 'publish_generated_columns'=false.
+-- Add generated columns in column list, when 'publish_generated_columns'=false
 ALTER PUBLICATION pub2 SET TABLE gencols(a, gen1);
 
 DROP PUBLICATION pub1;