v4-0008-review.patch
text/x-patch
Filename: v4-0008-review.patch
Type: text/x-patch
Part: 7
Patch
Format: format-patch
Series: patch v4-0008
Subject: review
| File | + | − |
|---|---|---|
| src/backend/replication/logical/reorderbuffer_compression.c | 4 | 1 |
From 7cbf94f473454987410373b6ca78e44c06b5fe08 Mon Sep 17 00:00:00 2001
From: Tomas Vondra <tomas@vondra.me>
Date: Tue, 17 Sep 2024 17:08:35 +0200
Subject: [PATCH v4 08/11] review
---
src/backend/replication/logical/reorderbuffer_compression.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/backend/replication/logical/reorderbuffer_compression.c b/src/backend/replication/logical/reorderbuffer_compression.c
index 96751852ef8..67068db9d2c 100644
--- a/src/backend/replication/logical/reorderbuffer_compression.c
+++ b/src/backend/replication/logical/reorderbuffer_compression.c
@@ -801,6 +801,9 @@ ReorderBufferCompress(ReorderBuffer *rb, ReorderBufferDiskHeader **header,
/* ZSTD Compression */
case REORDER_BUFFER_ZSTD_COMPRESSION:
{
+ /*
+ * XXX Same comment about palloc/pfree traffic as for lz4 ...
+ */
char *dst = NULL;
Size dst_size = 0;
char *src = (char *) rb->outbuf + sizeof(ReorderBufferDiskHeader);
@@ -928,7 +931,7 @@ ReorderBufferDecompress(ReorderBuffer *rb, char *data,
/* ZSTD streaming decompression */
case REORDER_BUFFER_STRAT_ZSTD_STREAMING:
{
- char *buf;
+ char *buf; /* XXX shouldn't this be set to NULL explicitly? */
Size src_size = header->size - sizeof(ReorderBufferDiskHeader);
Size buf_size = header->raw_size;
--
2.46.0