v4-0006-review.patch

From 8e243868ce9d6254480a239012bae730f4db77a9 Mon Sep 17 00:00:00 2001
From: Tomas Vondra <tomas@vondra.me>
Date: Tue, 17 Sep 2024 17:05:10 +0200
Subject: [PATCH v4 06/11] review

---
 .../replication/logical/reorderbuffer_compression.c       | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/backend/replication/logical/reorderbuffer_compression.c b/src/backend/replication/logical/reorderbuffer_compression.c
index 8d158aa51da..e8785d27e49 100644
--- a/src/backend/replication/logical/reorderbuffer_compression.c
+++ b/src/backend/replication/logical/reorderbuffer_compression.c
@@ -438,8 +438,16 @@ ReorderBufferCompress(ReorderBuffer *rb, ReorderBufferDiskHeader **header,
 			break;
 		}
 		/* PGLZ compression */
+		/*
+		 * XXX I'd probably start by adding pglz first, and only then add lz4 as a
+		 * separate patch, simply because pglz is the default and always supported,
+		 * while lz4 requires extra flags.
+		 */
 		case REORDER_BUFFER_PGLZ_COMPRESSION:
 		{
+			/*
+			 * XXX Same comment about palloc/pfree traffic as for lz4 ...
+			 */
 			int32		dst_size = 0;
 			char	   *dst = NULL;
 			char	   *src = (char *) rb->outbuf + sizeof(ReorderBufferDiskHeader);
-- 
2.46.0