PS_NITPICKS_20240829_DOCS_v430001.txt

text/plain

Filename: PS_NITPICKS_20240829_DOCS_v430001.txt
Type: text/plain
Part: 1
Message: Re: Introduce XID age and inactive timeout based replication slot invalidation
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fbbacbe..bd3ce5a 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -4568,8 +4568,8 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"'  # Windows
       </term>
       <listitem>
        <para>
-        Invalidates replication slots that are inactive for longer than
-        specified amount of time. If this value is specified without units,
+        Invalidate replication slots that are inactive for longer than this
+        amount of time. If this value is specified without units,
         it is taken as seconds. A value of zero (which is default) disables
         the timeout mechanism. This parameter can only be set in
         the <filename>postgresql.conf</filename> file or on the server
@@ -4577,18 +4577,16 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"'  # Windows
        </para>
 
        <para>
-        This invalidation check happens either when the slot is acquired
-        for use or during a checkpoint. The time since the slot has become
-        inactive is known from its
-        <structfield>inactive_since</structfield> value using which the
-        timeout is measured.
+        The timeout check occurs when the slot is next acquired for use, or
+        during a checkpoint. The slot's <structfield>inactive_since</structfield>
+        field value is when the slot became inactive.
        </para>
 
        <para>
         Note that the inactive timeout invalidation mechanism is not
         applicable for slots on the standby that are being synced from a
-        primary server (whose <structfield>synced</structfield> field is
-        <literal>true</literal>).
+        primary server (e.g. the standby slot <structfield>synced</structfield>
+        field is true).
        </para>
       </listitem>
      </varlistentry>
diff --git a/doc/src/sgml/system-views.sgml b/doc/src/sgml/system-views.sgml
index 9e00f7d..f230e6e 100644
--- a/doc/src/sgml/system-views.sgml
+++ b/doc/src/sgml/system-views.sgml
@@ -2621,7 +2621,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
         <listitem>
          <para>
           <literal>inactive_timeout</literal> means that the slot has been
-          inactive for the duration specified by
+          inactive for longer than the duration specified by
           <xref linkend="guc-replication-slot-inactive-timeout"/> parameter.
          </para>
         </listitem>